Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(mqtt-proxy): client id can be empty #5816

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix(mqtt-proxy): client id can be empty #5816

merged 1 commit into from
Dec 16, 2021

Conversation

spacewander
Copy link
Member

Fix #5802

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix(mqtt-proxy): client id can be empty
4df411b 
Fix apache#5802

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Copy link
Member Author

One can also use -i client_id to work around this, like mosquitto_pub -t test -m "Hallo" -p 9100 -i aaa.

@spacewander spacewander marked this pull request as ready for review December 15, 2021 03:41
@moonming moonming mentioned this pull request Dec 15, 2021
Closed
@spacewander spacewander merged commit de65fc4 into apache:master Dec 16, 2021
@spacewander spacewander deleted the mqte branch December 16, 2021 06:08
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Dec 30, 2021
@spacewander @bzp2010
fix(mqtt-proxy): client id can be empty (apache#5816)
b752e06
bzp2010 added a commit to bzp2010/apisix that referenced this pull request Dec 31, 2021
@bzp2010
fix(mqtt-proxy): client id can be empty (apache#5816)
5073c8e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: no connection to MQTT broker possible by using mqtt_proxy
3 participants
@spacewander @juzhiyuan @tokers