Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: support registering custom variable #5941

Merged
merged 3 commits into from
Dec 29, 2021
Merged

feat: support registering custom variable #5941

merged 3 commits into from
Dec 29, 2021

Conversation

spacewander
Copy link
Member

What this PR does / why we need it:

Fix #5634

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
ctxf
aa90fe8 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Merge branch 'master' of github.com:apache/incubator-apisix into ctxf
74a9b10 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review December 28, 2021 06:06
@juzhiyuan
Copy link
Member

Hi @leslie-tsang, could you please have a review?

@spacewander
doc the source
97e12ad 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit 0a8de20 into apache:master Dec 29, 2021
@spacewander spacewander deleted the ctxf branch December 29, 2021 03:39
@spacewander spacewander mentioned this pull request Jan 4, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@tokers tokers tokers approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request help: support get the key from function in limit-* plugins
5 participants
@spacewander @juzhiyuan @tokers @tzssangglass @leslie-tsang