-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add forward-auth plugin #6037
Changes from 28 commits
98d9671
da4c5ef
8525a76
868fced
1060fcb
1a14ab1
5952350
ea6d529
24882f8
eeaf575
bf5ade0
e31e6da
4209f5a
c2257c4
7ce1bac
e9d1fa6
18db978
211c37f
8a853d3
a84ddf9
67b1a7e
a4b05d9
6c73cbd
3df3ba5
63811b5
ac3ae02
8fef52c
07eb935
4fb97f7
868fa43
01f33f2
53f736b
6c6304c
96a23ba
ba64f8f
9565348
beea582
c49890f
a83e2b9
8d11c22
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
-- | ||
-- Licensed to the Apache Software Foundation (ASF) under one or more | ||
-- contributor license agreements. See the NOTICE file distributed with | ||
-- this work for additional information regarding copyright ownership. | ||
-- The ASF licenses this file to You under the Apache License, Version 2.0 | ||
-- (the "License"); you may not use this file except in compliance with | ||
-- the License. You may obtain a copy of the License at | ||
-- | ||
-- http://www.apache.org/licenses/LICENSE-2.0 | ||
-- | ||
-- Unless required by applicable law or agreed to in writing, software | ||
-- distributed under the License is distributed on an "AS IS" BASIS, | ||
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
-- See the License for the specific language governing permissions and | ||
-- limitations under the License. | ||
-- | ||
|
||
local ipairs = ipairs | ||
local core = require("apisix.core") | ||
local http = require("resty.http") | ||
|
||
local schema = { | ||
type = "object", | ||
properties = { | ||
host = {type = "string"}, | ||
ssl_verify = { | ||
type = "boolean", | ||
default = true, | ||
}, | ||
request_headers = { | ||
type = "array", | ||
default = {}, | ||
items = {type = "string"}, | ||
description = "client request header that will be sent to the authorization service" | ||
}, | ||
upstream_headers = { | ||
type = "array", | ||
default = {}, | ||
items = {type = "string"}, | ||
description = "authorization response header that will be sent to the upstream" | ||
}, | ||
client_headers = { | ||
type = "array", | ||
default = {}, | ||
items = {type = "string"}, | ||
description = "authorization response header that will be sent to" | ||
.. "the client when authorizing failed" | ||
}, | ||
timeout = { | ||
type = "integer", | ||
minimum = 1, | ||
maximum = 60000, | ||
default = 3000, | ||
description = "timeout in milliseconds", | ||
}, | ||
keepalive = {type = "boolean", default = true}, | ||
keepalive_timeout = {type = "integer", minimum = 1000, default = 60000}, | ||
keepalive_pool = {type = "integer", minimum = 1, default = 5}, | ||
}, | ||
required = {"host"} | ||
} | ||
|
||
|
||
local _M = { | ||
version = 0.1, | ||
priority = 2002, | ||
name = "forward-auth", | ||
schema = schema, | ||
} | ||
|
||
|
||
function _M.check_schema(conf) | ||
return core.schema.check(schema, conf) | ||
end | ||
|
||
|
||
function _M.access(conf, ctx) | ||
local auth_headers = { | ||
["X-Forwarded-Proto"] = core.request.get_scheme(ctx), | ||
["X-Forwarded-Method"] = core.request.get_method(), | ||
["X-Forwarded-Host"] = core.request.get_host(ctx), | ||
["X-Forwarded-Uri"] = ctx.var.request_uri, | ||
["X-Forwarded-For"] = core.request.get_remote_client_ip(ctx), | ||
} | ||
|
||
-- append headers that need to be get from the client request header | ||
if #conf.request_headers > 0 then | ||
for _, header in ipairs(conf.request_headers) do | ||
if not auth_headers[header] then | ||
auth_headers[header] = core.request.header(ctx, header) | ||
end | ||
end | ||
else | ||
auth_headers = core.table.merge(core.request.headers(), auth_headers) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because, merge the list of defined headers into the client request header, any key headers passed in by the client are overwritten, so I implement the untrusted client header. |
||
end | ||
|
||
local params = { | ||
method = "GET", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the request method be mapped to the client request method? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it's needed unless we provide other special features for this, the implementation in other software is the same. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In our or other forward-auth plugins, authentication-related data is sent via fixed requests, not POST data, so I think that's enough too. ping @shuaijinchao There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Oh, I get it. Modify will be made later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed |
||
headers = auth_headers, | ||
keepalive = conf.keepalive, | ||
ssl_verify = conf.ssl_verify | ||
} | ||
|
||
if conf.keepalive then | ||
params.keepalive_timeout = conf.keepalive_timeout | ||
params.keepalive_pool = conf.keepalive_pool | ||
end | ||
|
||
local httpc = http.new() | ||
httpc:set_timeout(conf.timeout) | ||
|
||
local res, err = httpc:request_uri(conf.host, params) | ||
|
||
-- block by default when authorization service is unavailable | ||
if err then | ||
core.log.error("failed to process forward auth, err: ", err) | ||
return 403 | ||
end | ||
|
||
if res.status >= 300 then | ||
local client_headers = {} | ||
|
||
if #conf.client_headers > 0 then | ||
for _, header in ipairs(conf.client_headers) do | ||
client_headers[header] = res.headers[header] | ||
end | ||
else | ||
client_headers = res.headers | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMHO, would be better to use allowlist? If no client_headers, no headers will be returned to the client. Some headers are not expected to be overridden, like Server / Date. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto, changed |
||
end | ||
|
||
core.response.set_header(client_headers) | ||
return res.status, res.body | ||
end | ||
|
||
-- append headers that need to be get from the auth response header | ||
for _, header in ipairs(conf.upstream_headers) do | ||
local header_value = res.headers[header] | ||
if header_value then | ||
core.request.set_header(ctx, header, header_value) | ||
end | ||
end | ||
end | ||
|
||
|
||
return _M |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
--- | ||
title: forward-auth | ||
--- | ||
|
||
<!-- | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
--> | ||
|
||
## Summary | ||
|
||
- [**Description**](#description) | ||
- [**Attributes**](#attributes) | ||
- [**Example**](#example) | ||
|
||
## Description | ||
|
||
The `forward-auth` plugin implements a classic external authentication model. We can implement a custom error return or user redirection to the authentication page if the authentication fails. | ||
|
||
Forward Auth cleverly moves the authentication and authorization logic to a dedicated external service, where the gateway forwards the user's request to the authentication service and blocks the original request, and replaces the result when the authentication service responds with a non-2xx status. | ||
|
||
## Attributes | ||
|
||
| Name | Type | Requirement | Default | Valid | Description | | ||
| -- | -- | -- | -- | -- | -- | | ||
| host | string | required | | | Authorization service host (eg. https://localhost:9188) | | ||
| ssl_verify | boolean | optional | true | | Whether to verify the certificate | | ||
| request_headers | array[string] | optional | | | `client` request header that will be sent to the `authorization` service. When it is not set, all `client` request headers are sent to the `authorization` service, except for those provided by APISIX (X-Forwarded-XXX). | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to update the doc There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||
| upstream_headers | array[string] | optional | | | `authorization` service response header that will be sent to the `upstream`. When it is not set, will not forward the `authorization` service response header to the `upstream`. | | ||
| client_headers | array[string] | optional | | | `authorization` response header that will be sent to the `client` when authorize failure. When it is not set, will not forward the `authorization` service response header to the `client`. | | ||
| timeout | integer | optional | 3000ms | [1, 60000]ms | Authorization service HTTP call timeout | | ||
| keepalive | boolean | optional | true | | HTTP keepalive | | ||
| keepalive_timeout | integer | optional | 60000ms | [1000, ...]ms | keepalive idle timeout | | ||
| keepalive_pool | integer | optional | 5 | [1, ...]ms | Connection pool limit | | ||
|
||
## Example | ||
|
||
First, you need to setup an external authorization service. Here is an example of using Apache APISIX's serverless plugin to mock. | ||
|
||
```shell | ||
$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/auth' \ | ||
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' \ | ||
-H 'Content-Type: application/json' \ | ||
-d '{ | ||
"uri": "/auth", | ||
"plugins": { | ||
"serverless-pre-function": { | ||
"phase": "rewrite", | ||
"functions": [ | ||
"return function (conf, ctx) local core = require(\"apisix.core\"); local authorization = core.request.header(ctx, \"Authorization\"); if authorization == \"123\" then core.response.exit(200); elseif authorization == \"321\" then core.response.set_header(\"X-User-ID\", \"i-am-user\"); core.response.exit(200); else core.response.set_header(\"Location\", \"http://example.com/auth\"); core.response.exit(403); end end" | ||
] | ||
} | ||
} | ||
}' | ||
``` | ||
|
||
Next, we create a route for testing. | ||
|
||
```shell | ||
$ curl -X PUT http://127.0.0.1:9080/apisix/admin/routes/1 | ||
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' | ||
-d '{ | ||
"uri": "/headers", | ||
"plugins": { | ||
"forward-auth": { | ||
"host": "http://127.0.0.1:9080/auth", | ||
"request_headers": ["Authorization"], | ||
"upstream_headers": ["X-User-ID"], | ||
"client_headers": ["Location"] | ||
} | ||
}, | ||
"upstream": { | ||
"nodes": { | ||
"httpbin.org:80": 1 | ||
}, | ||
"type": "roundrobin" | ||
} | ||
}' | ||
``` | ||
|
||
We can perform the following three tests. | ||
|
||
1. **request_headers** Send Authorization header from `client` to `authorization` service | ||
|
||
```shell | ||
$ curl http://127.0.0.1:9080/headers -H 'Authorization: 123' | ||
{ | ||
"headers": { | ||
"Authorization": "123", | ||
"Next": "More-headers" | ||
} | ||
} | ||
``` | ||
|
||
2. **upstream_headers** Send `authorization` service response header to the `upstream` | ||
|
||
```shell | ||
$ curl http://127.0.0.1:9080/headers -H 'Authorization: 321' | ||
{ | ||
"headers": { | ||
"Authorization": "321", | ||
"X-User-ID": "i-am-user", | ||
"Next": "More-headers" | ||
} | ||
} | ||
``` | ||
|
||
3. **client_headers** Send `authorization` service response header to `client` when authorizing failed | ||
|
||
```shell | ||
$ curl -i http://127.0.0.1:9080/headers | ||
HTTP/1.1 403 Forbidden | ||
Location: http://example.com/auth | ||
``` | ||
|
||
Finally, you can disable the `forward-auth` plugin by removing it from the route. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,7 @@ basic-auth | |
jwt-auth | ||
key-auth | ||
consumer-restriction | ||
forward-auth | ||
opa | ||
authz-keycloak | ||
proxy-mirror | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like we can't support forward no headers from the client?
If this field is empty, all headers are forwarded. What about don't provide a default value? (Use empty array if no headers are need)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's rightfully so, and that's an oversight on my part. I have reversed the meaning of
request_headers
andclient_headers
, if the user does not set this parameter, APISIX will send nothing.