fix(go/adbc/pkg): export Adbc* symbols on Windows #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Jul 19, 2023
| // ADBC_EXPORTING is required on Windows, or else the symbols | ||
| // won't be accessible to the driver manager | ||
|
|
||
| // #cgo CFLAGS: -DADBC_EXPORTING |
There was a problem hiding this comment.
Should we make the ADBC_EXPORTING only get defined on Windows? Or have it defined for all platforms?
There was a problem hiding this comment.
It's a no-op on other platforms. Eventually we can make it work like libarrow if we want, though (where they expand to [[gnu::visibility("default")]]/hidden)
zeroshade
approved these changes
Jul 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898.