Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[C++] Remove deprecated GetNextSegment #45744

Closed
AlenkaF opened this issue Mar 11, 2025 · 1 comment
Closed

[C++] Remove deprecated GetNextSegment #45744

AlenkaF opened this issue Mar 11, 2025 · 1 comment
Assignees
@AlenkaF
Labels
Component: C++ Type: enhancement
Milestone
20.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Mar 11, 2025

Describe the enhancement requested

Remove GetNextSegment and related from compute/row/grouper.cc, the code has been deprecated in 18.0.0. See: #44053

Component(s)

C++
@AlenkaF AlenkaF self-assigned this Mar 11, 2025
@github-actions github-actions bot mentioned this issue Mar 11, 2025
Merged
zanmato1984 added a commit that referenced this issue Mar 12, 2025
@AlenkaF @zanmato1984
GH-45744: [C++] Remove deprecated GetNextSegment (#45745)
4291dad 
### Rationale for this change
`GetNextSegment` has been deprecated in 18.0.0 and can now be removed. 

### What changes are included in this PR?
`GetNextSegment` and related code is removed from compute/row/grouper.cc/.h.

### Are these changes tested?
The existing tests should pass.

### Are there any user-facing changes?
`GetNextSegment` is removed in favour of `GetSegment`
* GitHub Issue: #45744

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
@zanmato1984
Copy link
Contributor

Issue resolved by pull request 45745
#45745

@zanmato1984 zanmato1984 added this to the 20.0.0 milestone Mar 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@zanmato1984 @AlenkaF