GH-45570: [Python] Allow Decimal32/64Array.to_pandas #45571
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
raulcd
approved these changes
Feb 19, 2025
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting changes
pitrou
reviewed
Feb 19, 2025
python/pyarrow/tests/test_pandas.py
Outdated
Comment on lines
2044
to
2048
| @pytest.mark.parametrize("typ", [ | ||
| pa.decimal32, | ||
| pa.decimal64, | ||
| pa.decimal128, | ||
| ]) |
There was a problem hiding this comment.
Can you add decimal256 into the mix, or does it actually not work?
There was a problem hiding this comment.
Sure, added decimal256 as it appears to work
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ce012eb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Enables converting
Decimal32ArrayandDecimal64Arrayto pandasWhat changes are included in this PR?
Adds
Type::DECIMAL32andType::DECIMAL64as convertible types to pandasAre these changes tested?
Yes
Are there any user-facing changes?
Yes
closes #45570