Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[prism] Support Gauge Metrics #31928

Closed
Tracked by #29650
lostluck opened this issue Jul 17, 2024 · 0 comments
Closed
Tracked by #29650

[prism] Support Gauge Metrics #31928

lostluck opened this issue Jul 17, 2024 · 0 comments
Labels
go prism
Milestone
2.59.0 Release

Comments

@lostluck
Copy link
Contributor

lostluck commented Jul 17, 2024 •
edited
Loading

Similar to #31927, but implement Gauge Metrics.

A metric accumulator will need to be added for the type in prism:

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go#L357

And adding the type to the accumulator factory list:

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go#L168

Specifically with the right URNs and coders:

https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/metrics.proto#L520

Once unfiltered, this will allow the following Java Validates Runner tests to pass.

MetricsTest.testCommittedGaugeMetrics
MetricsTest.testAttemptedGaugeMetrics
@lostluck lostluck mentioned this issue Jul 17, 2024
Open
@lostluck lostluck changed the title [prism] Support Guage Metrics [prism] Support Gauge Metrics Aug 14, 2024
@lostluck lostluck mentioned this issue Aug 14, 2024
Merged
3 tasks
lostluck added a commit that referenced this issue Aug 15, 2024
@lostluck
[#31927,#31928][prism] Support StringSet and Gauge metrics. (#32184)
11befd3 
* Update Generated Go Protos

* [prism] Add stringset and gauge metrics

* lint + tests

---------

Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
@github-actions github-actions bot added this to the 2.59.0 Release milestone Aug 16, 2024
reeba212 pushed a commit to reeba212/beam that referenced this issue Dec 4, 2024
@lostluck @reeba212
[apache#31927,apache#31928][prism] Support StringSet and Gauge metric…
a4fa5ef 
…s. (apache#32184)

* Update Generated Go Protos

* [prism] Add stringset and gauge metrics

* lint + tests

---------

Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
go prism
Projects
None yet
Milestone
2.59.0 Release
Development

No branches or pull requests
1 participant
@lostluck