[#28126] plumb coder errors with better context. #28164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The precommit Jenkins failure is due to and the GA one is a flake in Log message guarantees WRT pipeline completion. |
Codecov Report
@@ Coverage Diff @@
## master #28164 +/- ##
==========================================
- Coverage 72.32% 72.29% -0.04%
==========================================
Files 678 678
Lines 99802 99839 +37
==========================================
- Hits 72184 72179 -5
- Misses 26054 26085 +31
- Partials 1564 1575 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Go PreCommit |
|
Run Go PreCommit |
lostluck
added a commit
to lostluck/beam
that referenced
this pull request
Aug 30, 2023
* [apache#28126] plumb coder errors with better context. * Add hard clear checks for SDK error: no windows being encoded. * parse log * fix log line parsing * fmt --------- Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling around panics and length prefixing unknown coders.
There's more work to do on this, but this should assist in executing the Swift SDK on prism.
Partly handles #28126 and related to #28187.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.