-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[prism] Dev prism builds for python and Python Direct Runner fallbacks. #32876
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM once checks pass (https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks may help)
I discovered the root of my problem was using a newer yapf than Beam does, (0.40, instead of 0.29), so now I can have the formatting enabled on save, which will help! Local Linting on the other hand eludes me. I'm fortunately not tickling that as often. |
This change does two tasks:
The main change is to the prism_runner behavior when the SDK reports a
.dev
version.In that case:
go install github.com/apache/beam/sdks/v2/go/cmd/prism
to the binary cache directory.Arguably independently, is Attempt To Use Prism in the direct runner.
Other changes are a refactor to reverse a few if blocks and return earlier, improving readability and reducing indentations.
Part of #32564
Fixes #32877.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.