Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Aggregation option in Kinesis Writer Python sdk #34323

Merged

Conversation

Nakachi-S
Copy link
Contributor

@Nakachi-S Nakachi-S commented Mar 17, 2025

addresses #34319

I have added an option to do aggregation in the apache_beam.io.kinesis module.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Nakachi-S Nakachi-S marked this pull request as ready for review March 17, 2025 15:18
@Nakachi-S
Copy link
Contributor Author

@damccorm
Hi!
I opened the issue in the comments and created this PR.
Could you please review it?

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @kennknowles for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this generally looks like a good change to me, just had one comment

@Nakachi-S Nakachi-S requested a review from damccorm March 18, 2025 15:05
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this mostly LGTM, would you mind fixing the failing lint/format checks though? You can see how to do this here - https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks

@Nakachi-S
Copy link
Contributor Author

@damccorm
Thanks for checking.
Some CI checks are failing.
I checked and I don't think those failures are related to my changes, how can I help?

@damccorm
Copy link
Contributor

@damccorm Thanks for checking. Some CI checks are failing. I checked and I don't think those failures are related to my changes, how can I help?

I agree, these looked like transient flakes - I reran the checks and they passed

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 6147d44 into apache:master Mar 19, 2025
102 checks passed
talatuyarer pushed a commit to talatuyarer/beam that referenced this pull request Mar 20, 2025
* 👍 Add aggregation feature

* 🐛 Fix import bug

* ✅ Add test

* 👍 Add 3 argument

* 💡 Add comment

* 🎨 Format code
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants