Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BEAM-7798] [BEAM-7060] Native types with revert and fix. #9125

Merged
merged 3 commits into from
Jul 24, 2019
Merged

[BEAM-7798] [BEAM-7060] Native types with revert and fix. #9125

merged 3 commits into from
Jul 24, 2019

Conversation

robertwb
Copy link
Contributor

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robertwb
Copy link
Contributor Author

R: @udim, @tvalentyn

@robertwb
Copy link
Contributor Author

Run Python Postcommit

@robertwb
Copy link
Contributor Author

Run Python 3.5 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 2 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 3.7 PostCommit

@robertwb robertwb force-pushed the native-types-fix-with-revert-and-fix branch from 16eebb5 to 477581b Compare July 23, 2019 10:52
@robertwb
Copy link
Contributor Author

Run Python 3.7 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 3.5 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 2 PostCommit

@robertwb robertwb force-pushed the native-types-fix-with-revert-and-fix branch from 477581b to d080028 Compare July 23, 2019 12:10
@robertwb
Copy link
Contributor Author

Run Python 3.5 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 3.7 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 2 PostCommit

@tvalentyn
Copy link
Contributor

Run Python 3.6 PostCommit

@udim
Copy link
Member

udim commented Jul 23, 2019

Run Python 2 PostCommit

1 similar comment
@robertwb
Copy link
Contributor Author

Run Python 2 PostCommit

@robertwb
Copy link
Contributor Author

Run Python 3.6 PostCommit

@robertwb
Copy link
Contributor Author

The apache_beam.io.gcp.datastore_write_it_test.DatastoreWriteIT error looks completely irrelevant (and is happening on other PRs as well).

udim
udim approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@udim udim mentioned this pull request Jul 23, 2019
Closed
3 tasks
@robertwb robertwb merged commit 4935d0c into apache:master Jul 24, 2019
@udim udim mentioned this pull request Jul 24, 2019
Closed
@chadrik
Copy link
Contributor

chadrik commented Jul 24, 2019

I noticed that transforms.core is still using typehints.TypeVariable

Is that intentional?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@udim udim udim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertwb @tvalentyn @udim @chadrik