Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add support for rwlock, a classic approach #1034

Closed
wants to merge 1 commit into from

Conversation

xiaosage079
Copy link

#1031 got error when travis-ci do linking like bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to `bvar::detail::Percentile::Percentile()', but we did not modifie bvar, so I rePR, to see if there are still errors.

@zyearn
Copy link
Member

zyearn commented Jan 20, 2020

Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it can pass ut this time. If it passes, this pr can be closed.

@xiaosage079
Copy link
Author

Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it can pass ut this time. If it passes, this pr can be closed.

1031 passed, i will close this pr.

@hairet
Copy link

hairet commented Jan 21, 2020

Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it can pass ut this time. If it passes, this pr can be closed.

1031 passed, i will close this pr.

thank you,nice job

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants