Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add avg latency for prometheus metrics #2024

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

Huixxi
Copy link
Contributor

@Huixxi Huixxi commented Nov 28, 2022

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@Huixxi
Copy link
Contributor Author

Huixxi commented Nov 28, 2022

Fix #2012

@zyearn
Copy link
Member

zyearn commented Nov 28, 2022

这个可能得加在其它地方,这个函数export的是Histogram
类型 https://prometheus.io/docs/concepts/metric_types/#histogram

@wwbmmm
Copy link
Contributor

wwbmmm commented Nov 28, 2022

这个可能得加在其它地方,这个函数export的是Histogram 类型 https://prometheus.io/docs/concepts/metric_types/#histogram

应该不是Histogram,是Summary类型
https://github.com/apache/incubator-brpc/blob/master/src/brpc/builtin/prometheus_metrics_service.cpp#L159

@zyearn
Copy link
Member

zyearn commented Nov 28, 2022

这个可能得加在其它地方,这个函数export的是Histogram 类型 https://prometheus.io/docs/concepts/metric_types/#histogram

应该不是Histogram,是Summary类型 https://github.com/apache/incubator-brpc/blob/master/src/brpc/builtin/prometheus_metrics_service.cpp#L159

嗯嗯是Summary。

@serverglen
Copy link
Contributor

LGTM

@serverglen serverglen added the feature new feature label Nov 30, 2022
@lorinlee
Copy link
Contributor

summary的quantile写avg是Prometheus支持的吗,这个有相关文档不,我搜了下只找到了quantile里是百分比数字的,还有_sum和_count

@cdjingit cdjingit merged commit d810d0c into apache:master Feb 6, 2023
@Huixxi Huixxi deleted the avg-latency branch March 25, 2023 15:45
@Huixxi
Copy link
Contributor Author

Huixxi commented Apr 18, 2023

label可以是自定义字符串,这里命名是“avg”,具体的值是si->latency_avg。

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants