Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Force SSL for all connections of Acceptor #2231

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Force SSL for all connections of Acceptor #2231

merged 3 commits into from
Jun 25, 2023

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented May 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: fix #2194

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright added the feature new feature label May 3, 2023
@wwbmmm
Copy link
Contributor

wwbmmm commented May 5, 2023

这样会不会内置服务也不能用了？

@chenBright
Copy link
Contributor Author

服务应该要提供浏览器信任的SSL证书，内置服务才能用了

@wwbmmm
Copy link
Contributor

wwbmmm commented May 5, 2023

如果指定了internal_port，将内置服务启动在单独的端口，能否只对主端口强制SSL，internal_port不生效呢？
也就是说，强制SSL这个flag应该是一个Acceptor级别的，而不是全局的

@chenBright
Copy link
Contributor Author

这样可以

@chenBright chenBright changed the title Force SSL for all connections Force SSL for all connections of Acceptor May 5, 2023
@chenBright
Copy link
Contributor Author

@wwbmmm 修改为按Acceptor级别强制使用SSL

wwbmmm
wwbmmm reviewed May 6, 2023
View reviewed changes
@wwbmmm
Copy link
Contributor

wwbmmm commented May 8, 2023

LGTM

@wwbmmm wwbmmm merged commit bc6f30d into apache:master Jun 25, 2023
@chenBright chenBright deleted the force_ssl branch June 25, 2023 06:42
@chenBright chenBright linked an issue Jun 25, 2023 that may be closed by this pull request
Force SSL for all connections if user enabled SSL #2194
Closed
@chenBright chenBright removed a link to an issue Jun 25, 2023
Force SSL for all connections if user enabled SSL #2194
Closed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@chenBright
Force SSL for all connections of Acceptor (apache#2231)
90a1654 
* Force SSL for all connections

* Force SSL for all connections of Acceptor

* Force SSL option in ServerOptions
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wwbmmm wwbmmm wwbmmm left review comments

Assignees
No one assigned
Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force SSL for all connections if user enabled SSL
2 participants
@chenBright @wwbmmm