Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix compilation errors reported by clang-14 (#2242) #2243

Merged
merged 1 commit into from
May 23, 2023

Conversation

thorneliu
Copy link
Contributor

What problem does this PR solve?

Issue Number:
#2242

Problem Summary:
(warning: variable 'nremoved' set but not used [-Wunused-but-set-var)

What is changed and the side effects?

remove not used variable to fix the compile warnnings

Changed:

Side effects:

  • Performance effects(性能影响):
    No impact

  • Breaking backward compatibility(向后兼容性):
    No compatibility issue


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@TousakaRin
Copy link
Contributor

LGTM, 检查了一下历史记录,这些变量在第一版的提交里就是unused

@serverglen serverglen merged commit d5327f6 into apache:master May 23, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants