Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix redis server example handler memory leak #2370

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ehds
Copy link
Contributor

@ehds ehds commented Sep 4, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

Redis service handler should be released after server stopped.

What is changed and the side effects?

Changed:

Using unique_ptr wrap GetCommandHandler and SetCommandHandler pointer.

Side effects:

  • Performance effects(性能影响):
    No
  • Breaking backward compatibility(向后兼容性):
    No

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@serverglen
Copy link
Contributor

LGTM

@serverglen serverglen merged commit 0a940cd into apache:master Sep 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants