Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reserve at least one idle socket #2390

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Sep 20, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

目前brpc会将连接池里空闲的连接关闭,这样对于比较低频的rpc来说,如果rpc周期大于FLAGS_idle_timeout_second,那每次都要新建连接,不太友好。

What is changed and the side effects?

Changed:

支持连接池保留至少一个空闲连接。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 22, 2023

把FLAGS_idle_timeout_second设置为大于rpc周期就可以了吧?

@chenBright
Copy link
Contributor Author

一些场景下,FLAGS_idle_timeout_second不好确定。rpc周期不是固定的,可能是基于事件的。

FLAGS_idle_timeout_second设置太大的话,那些连接数比较多的池就不会释放连接了。

@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 26, 2023

LGTM

@chenBright
Copy link
Contributor Author

没有其他问题的话,这个PR应该可以合了

@wwbmmm wwbmmm merged commit a3becd3 into apache:master Oct 25, 2023
@chenBright chenBright deleted the reserve_one_idle_socket branch October 25, 2023 07:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants