-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support compile with boringssl #2399
Conversation
a4a51af
to
3306106
Compare
3306106
to
20a619d
Compare
80810b9
to
56a90ad
Compare
.github/workflows/ci-linux.yml
Outdated
@@ -95,7 +95,9 @@ jobs: | |||
run: | | |||
export CC=gcc && export CXX=g++ | |||
bazel build -j 12 -c opt --define with_mesalink=false --define with_glog=true --define with_thrift=true --copt -DHAVE_ZLIB=1 //... | |||
|
|||
- name: compile-with-boringssl | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加上这个step之后,gcc-compile-with-bazel-all-options的运行时间达到了1个小时
可否拆成两个并行的任务?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 新增 gcc-compile-with-boringssl
任务
.github/workflows/ci-linux.yml
Outdated
@@ -178,6 +180,9 @@ jobs: | |||
run: | | |||
export CC=clang && export CXX=clang++ | |||
bazel build -j ${{env.proc_num}} -c opt --define with_mesalink=false --define with_glog=true --define with_thrift=true --copt -DHAVE_ZLIB=1 //... | |||
- name: compile-with-boringssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 新增 clang-compile-with-boringssl
任务
LGTM |
* support boringssl * add CMakeLists * fix * suopport boring ssl bazel * fix AddBioBuffer code * fix compile * add boringssl compile bazel ci * set compile with boringssl as a dependent job --------- Co-authored-by: Dongsheng He <hds@dipeak.com>
@ehds 我尝试了下用boringssl,打开http_verbose,有打印发送请求的信息,但是收不到回复。如果把AddBIOBuffer去掉,能够正常运作。可能BIO_s_mem并不能代替BIO_f_buffer auto m1 = BIO_new(BIO_s_mem()); 输出: |
What problem does this PR solve?
Issue Number: #1255 #2167
Problem Summary: Support bRPC compile with boringssl
What is changed and the side effects?
Changed:
增加兼容函数:
AddBIOBuffer
, boringssl 没有BIO_f_buffer
函数, 使用BIO_s_mem
代替get_rfc2409_prime_xxx
等一些函数,需要使用 sssl_compat.h 中提供的。目前仅支持 CMake/Bazel 的编译方式
支持的 boringssl 版本 fips-20210429
Side effects:
无
无
Check List: