Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FIX] fix compile on ubuntu18.04 + use anonymous namespace for hardco… #2422

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Simonhancrew
Copy link
Contributor

@Simonhancrew Simonhancrew commented Oct 23, 2023

Problem Summary:

  1. comile error on ubuntu18.04, BRPC/src/brpc/redis_command.cpp:411:29: error: ‘numeric_limits’ is not a member of ‘std’
  2. CTX_WIDTH should in anonymous namespace, only used in this cpp file.

Changed:

  1. compile on ubuntu18.04, redis_commands.cpp use numeric_limits<>, while missing header, cause compile error
  2. use anonymous namespace for hardcode var, dont emit this to brpc namespace

Side effects:

  • no side effect

@Simonhancrew
Copy link
Contributor Author

@wwbmmm 烦请老哥take a look, 谢谢

@wwbmmm wwbmmm merged commit 3527165 into apache:master Oct 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants