Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

span for new bthread #2519

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

yanglimingcn
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@yanglimingcn yanglimingcn force-pushed the feature/span_for_new_bthread branch 2 times, most recently from 9eaa8e0 to a90a321 Compare January 29, 2024 01:22
@yanglimingcn
Copy link
Contributor Author

yanglimingcn commented Jan 29, 2024

这个是什么地方单测失败了,看不出来呢?显示不出来呢 @wwbmmm

@yanglimingcn yanglimingcn force-pushed the feature/span_for_new_bthread branch from a90a321 to ecf6c16 Compare January 31, 2024 03:55
@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 31, 2024

这个是什么地方单测失败了,看不出来呢?显示不出来呢 @wwbmmm

最新master分支已修复,可以更新试试

@yanglimingcn yanglimingcn force-pushed the feature/span_for_new_bthread branch 2 times, most recently from 56be2c4 to 491e247 Compare February 4, 2024 10:50
@yanglimingcn yanglimingcn force-pushed the feature/span_for_new_bthread branch from 491e247 to 56c86cb Compare February 5, 2024 01:25
@yanglimingcn
Copy link
Contributor Author

@wwbmmm 这个PR有时间可以review了。

@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 9, 2024

LGTM

@wwbmmm wwbmmm merged commit 24fc31e into apache:master Feb 26, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants