Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MPSQ] fix a memleak in butil::ObjectPoolAllocator #2725

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

live4thee
Copy link
Contributor

Without specifying the type of the pointer, the memory will return to the pool holding all `void' pointers.

What problem does this PR solve?

Issue Number: #2724

Problem Summary: see issue #2724

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Without specifying the type of the pointer, the memory will return to
the pool holding all `void' pointers.

Signed-off-by: Qun, Li <qun.li@zstack.io>
@wasphin wasphin requested a review from chenBright August 6, 2024 05:15
Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright linked an issue Aug 6, 2024 that may be closed by this pull request
@chenBright chenBright merged commit b4d4acb into apache:master Aug 6, 2024
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory leak in butil::ObjectPoolAllocator
2 participants