Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support timedlock of fast/hook pthread and bthread::Mutex #2760

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Sep 9, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

  1. linux上未支持pthread_mutex_timedlock contention profile;
  2. FastPthreadMutex未支持timedlock以及对应的contention profile;
  3. 使用pthread_mutex_timedlock后,Support pthread mutex deadlock detection #2692 会误判。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright force-pushed the timedlock branch 3 times, most recently from ad75348 to 5f8b95e Compare September 12, 2024 02:46
@chenBright chenBright changed the title Support fast/hook pthread timedlock Support timedlock of fast/hook pthread and bthread::Mutex Sep 12, 2024
@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 20, 2024

LGTM

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 7, 2024

@chenBright 和主干冲突了

@chenBright chenBright force-pushed the timedlock branch 2 times, most recently from a254ee8 to 10706d0 Compare October 8, 2024 16:19
@chenBright
Copy link
Contributor Author

  1. rebase解决冲突。
  2. 鉴于pthread_mutex_lock/pthread_mutex_unlock可以在不同线程执行,默认关闭 Support pthread mutex deadlock detection #2692 的检测功能。

@wwbmmm wwbmmm merged commit 9680d31 into apache:master Oct 9, 2024
20 checks passed
@chenBright chenBright deleted the timedlock branch October 31, 2024 02:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants