Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NonreflectableMessage and support Protobuf v5 #2782

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

wasphin
Copy link
Member

@wasphin wasphin commented Oct 14, 2024

See #2722 (comment) inspired by unreflectable_message of @oathdruid.

What problem does this PR solve?

Issue Number: #2757

Problem Summary:

隔离 Protobuf Message API,简化内部消息类型实现,简化后续 Protobuf 适配工作,支持 Protobuf 到 v5.28.0

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin wasphin force-pushed the feature/nonreflectable-message branch from b3ff132 to c8c6cc9 Compare October 14, 2024 16:41
@wasphin wasphin force-pushed the feature/nonreflectable-message branch from c8c6cc9 to 807dc93 Compare October 16, 2024 03:52
@wasphin wasphin marked this pull request as ready for review October 19, 2024 08:33
@wasphin wasphin requested review from wwbmmm and chenBright October 21, 2024 05:11
@chenBright chenBright linked an issue Oct 26, 2024 that may be closed by this pull request
@wasphin
Copy link
Member Author

wasphin commented Oct 29, 2024

ci 问题看和改动无关,暂时没有 bazel 测试环境,得晚几天再看看

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 29, 2024

LGTM

@oathdruid
Copy link
Contributor

ci 问题看和改动无关,暂时没有 bazel 测试环境,得晚几天再看看

看起来boost.uuid@1.83.0还是有点问题,PR预期boost.uuid@1.83.0.bcr.1能修复;我先给这个发布到babylon的registry了,应该能先跑起来;等bcr的merge进去可以无缝替换

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit 282776a into apache:master Oct 30, 2024
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf v5 support
4 participants