Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Panic with odd number of key / value arguments #3587

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: Panic with odd number of key / value arguments #3587

merged 1 commit into from
Aug 30, 2022

Conversation

astefanutti
Copy link
Member

Release Note

fix: Panic with odd number of key / value arguments

@astefanutti
Copy link
Member Author

The CI failures are unrelated. Let me merge this.

@astefanutti astefanutti merged commit 95e0123 into apache:main Aug 30, 2022
@astefanutti astefanutti deleted the pr-423 branch August 30, 2022 14:09
@tadayosi
Copy link
Member

@astefanutti Validation started to fail from here.

@tadayosi
Copy link
Member

tadayosi commented Aug 31, 2022

It's baffling but indeed reverting the commit clears the validate failure.
https://github.com/tadayosi/camel-k/runs/8106868130?check_suite_focus=true
Possibly it has been just the last straw for something with linting? Anyway we'd like to remove the linting failure in any way.

@tadayosi tadayosi mentioned this pull request Aug 31, 2022
@astefanutti
Copy link
Member Author

@tadayosi yes, these are new issues unrelated to that PR. Maybe we'll want to add only-new-issues: true to the golangci-lint action configuration.

@astefanutti astefanutti added the kind/bug Something isn't working label Sep 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants