Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat/coverage badge #4260

Merged
merged 28 commits into from
Apr 15, 2023
Merged

Feat/coverage badge #4260

merged 28 commits into from
Apr 15, 2023

Conversation

realMartinez
Copy link
Contributor

@realMartinez realMartinez commented Apr 14, 2023 •
edited by squakez
Loading

  • Added golang unit test coverage badge
  • Added nightly workflow for the badge update
  • Updated README.adoc

Release Note

feat (ci): coverage badge

Martin Olsiak and others added 28 commits April 13, 2023 16:29
coverage_badge
102a4bf
added on pull for testing
99b51e5
@github-actions
chore: nightly coverage badge
40d71d5
@realMartinez
Update README.adoc
2d9dbef
@realMartinez
Update README.adoc
fe6136b
@realMartinez
Update README.adoc
28b2b57
@realMartinez
Update README.adoc
fba25b2
@realMartinez
Update README.adoc
10a1ff4
@github-actions
chore: nightly coverage badge
d212a1d
changed coverage badge format to adoc
1f34181
@realMartinez
Update README.adoc
18cf634
Go Coverage Action edit
d7d5b72
Go Coverage Action edit
a1d2e96
Coverage Badge Action edit
cab57f3
Go Coverage Badge edit
7a60e26
Go Coverage Badge Action edit
309dd67
@github-actions
chore: nightly coverage badge
b03c576
Added Conversion from md to adoc for badge
9c75a04
Go Coverage Badge action edit
fd6922c
@realMartinez
Update README.adoc
c781281
Updated Regex in Convert Badge
cbad792
Conver Badge to adoc edit
3ffa8f1
@github-actions
chore: nightly coverage badge
69aa919
@realMartinez
Update README.adoc
f788da1
@github-actions
chore: nightly coverage badge
253be89
renamed badge coverage workflow
3b0ca98
@realMartinez
Update README.adoc
ab47fda
Changed Push changes action
f65a6db
squakez
squakez approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. I am not 100% sure that the tj-actions/verify-changed-files will run correctly in main fork (due to Apache policy). If not, I will check with INFRA team or alternatively we can workaround copying the execution of that action.

oscerd
oscerd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commits? Thanks

@squakez
Copy link
Contributor

squakez commented Apr 14, 2023

Can you please squash the commits? Thanks

Yes, we'll squash before merging from github directly.

@squakez squakez added the kind/feature New feature or request label Apr 14, 2023
@squakez squakez linked an issue Apr 14, 2023 that may be closed by this pull request
Introduce Code Coverage badge #4227
Closed
@squakez squakez merged commit 769c625 into apache:main Apr 15, 2023
@realMartinez realMartinez deleted the feat/coverage_badge branch May 30, 2023 11:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Code Coverage badge
3 participants
@realMartinez @squakez @oscerd