Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove empty CRD yaml #4498

Closed
wants to merge 1 commit into from
Closed

fix: remove empty CRD yaml #4498

wants to merge 1 commit into from

Conversation

anhpngt
Copy link
Contributor

@anhpngt anhpngt commented Jun 21, 2023

Fixes #4497

Release Note

Fix CRD installation when using Helm

This fixes helm installation
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a leftover from previous naming. The files has to be completely removed.

@anhpngt
Copy link
Contributor Author

anhpngt commented Jun 22, 2023

thanks @squakez for taking a look!

could you elaborate on "completely removing" the files?

in the meanwhile i'll take a look at the failed tests

@squakez
Copy link
Contributor

squakez commented Jun 22, 2023

Tests were failing because of some infra problem that should have gone. Don't worry about them. What I meant is that the file should be completely removed. It seems to be a leftover from the previous renaming from KameletBinding to Binding which eventually became Pipe.

@squakez
Copy link
Contributor

squakez commented Jun 23, 2023

I'm colsing this in favour of #4510 - the problem is in the release process which is not taking in account properly the generation of charts when run from release branches.

@squakez squakez closed this Jun 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart 0.13.1 failed to install
2 participants