Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CAMEL-18276] : azure-service-bus component support for session enabled entities #16826

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

Pulin412
Copy link
Contributor

Description

Session support for azure-service-bus component. Existing component is updated to handle both non-session (existing functionality) and session based entities.

New properties are added -

  • sessionId - For producer, sessionId is required to send with message while publishing message for session based entities.
  • sessionEnabled - For consumer, boolean flag to let the consumer create Session aware clients to consume messages from session aware entities.

JIRA Issue - https://issues.apache.org/jira/browse/CAMEL-18276

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.

  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd like to have feedback from @dylanpiergies and @davsclaus

@Pulin412 Pulin412 marked this pull request as ready for review January 16, 2025 04:51
@davsclaus davsclaus merged commit c35b957 into apache:main Jan 16, 2025
3 of 5 checks passed
@davsclaus
Copy link
Contributor

I wonder if sessionEnabled should be an option on component level, so you can configure this once if you always want to use this. And if so you are welcome to work on that for another PR

@dylanpiergies
Copy link
Contributor

Seems OK to me. I've double checked the integration tests are passing, since they don't run during builds. All good. Aside from that, I haven't really delved into the nuts and bolts of the session functionality with Service Bus. I'd have to spend some time looking through the Azure documentation to see if there are any additions that need to be made for full-featured session support.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants