CAMEL-13042: File producer should by default only allow to write file… #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the starting directory (or subs). Added new option to turn this on|off.
onderson
reviewed
Jan 8, 2019
There was a problem hiding this comment.
when it is said jailStartingDirectory as the option and defaulting it to true, i understood that by default, write operations will be disabled for file producer to write other than default or its sub directories, resulting with illegalarguement exception. however, test method names are confusing for such implementation. wouldn't it be better to swap test method names regarding such feature?
| super.setUp(); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
@test(expected = IllegalArgumentException.class)
There was a problem hiding this comment.
Ah okay yeah we can rename the test methods
zregvart
approved these changes
Jan 9, 2019
davsclaus
added a commit
that referenced
this pull request
Jan 9, 2019
#2700) * CAMEL-13042: File producer should by default only allow to write files in the starting directory (or subs). Added new option to turn this on|off. * CAMEL-13042: Regen docs * CAMEL-13042: Polished
davsclaus
added a commit
that referenced
this pull request
Jan 11, 2019
#2700) * CAMEL-13042: File producer should by default only allow to write files in the starting directory (or subs). Added new option to turn this on|off. * CAMEL-13042: Regen docs * CAMEL-13042: Polished
davsclaus
added a commit
that referenced
this pull request
Jan 11, 2019
#2700) * CAMEL-13042: File producer should by default only allow to write files in the starting directory (or subs). Added new option to turn this on|off. * CAMEL-13042: Regen docs * CAMEL-13042: Polished
davsclaus
added a commit
that referenced
this pull request
Jan 11, 2019
#2700) * CAMEL-13042: File producer should by default only allow to write files in the starting directory (or subs). Added new option to turn this on|off. * CAMEL-13042: Regen docs * CAMEL-13042: Polished
tdiesler
pushed a commit
to tdiesler/camel
that referenced
this pull request
Feb 20, 2019
apache#2700) * CAMEL-13042: File producer should by default only allow to write files in the starting directory (or subs). Added new option to turn this on|off. * CAMEL-13042: Regen docs * CAMEL-13042: Polished
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s in the starting directory (or subs). Added new option to turn this on|off.