Skip to content

Commit

Permalink
[CELEBORN-1865] Update master endpointRef when master leader is abnormal
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
`rpcEndpointRef` should be set to `null` When master leader is not present.

### Why are the changes needed?
Attempt master address index can only be updated when `rpcEndpointRef` is `null`.

The index wont update  if `rpcEndpointRef` has been set but some error ocurs to the master leader.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

Closes #3101 from zaynt4606/clb1865.

Authored-by: zhengtao <shuaizhentao.szt@alibaba-inc.com>
Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
  • Loading branch information
zaynt4606 authored and RexXiong committed Feb 20, 2025
1 parent d659e06 commit 27c6605
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ private boolean shouldRetry(@Nullable RpcEndpointRef oldRef, Throwable e) {
setRpcEndpointRef(leaderAddr);
} else {
LOG.warn("Master leader is not present currently, please check masters' status!");
resetRpcEndpointRef(oldRef);
}
return true;
} else if (e.getCause() instanceof IOException || e instanceof RpcTimeoutException) {
Expand Down

0 comments on commit 27c6605

Please # to comment.