[CELEBORN-1763] Fix DataPusher be blocked for a long time #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blocked for a long time
turboFei
approved these changes
Dec 23, 2024
turboFei
pushed a commit
that referenced
this pull request
Dec 23, 2024
### What changes were proposed in this pull request? fix DataPusher be blocked for a long time ### Why are the changes needed? The worker has been at a performance bottleneck for a long time, the slow start strategy adjusts its maxInFlight to 1, which may cause RequestInFlight to exceed maxInFlight. If the task’s main thread has been blocked in the waitIdleQueueFullWithLock call, then the main thread will not be able to detect the sending failure since this failure changes the exception in the push state, and the waitIdleQueueFullWithLock function does not check for it ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? GA Closes #2978 from zhaostu4/fix_pusher_block. Authored-by: zhangzhao.08 <zhangzhao.08@bytedance.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 9e04ff4) Signed-off-by: Wang, Fei <fwang12@ebay.com>
turboFei
pushed a commit
that referenced
this pull request
Dec 23, 2024
fix DataPusher be blocked for a long time The worker has been at a performance bottleneck for a long time, the slow start strategy adjusts its maxInFlight to 1, which may cause RequestInFlight to exceed maxInFlight. If the task’s main thread has been blocked in the waitIdleQueueFullWithLock call, then the main thread will not be able to detect the sending failure since this failure changes the exception in the push state, and the waitIdleQueueFullWithLock function does not check for it NO GA Closes #2978 from zhaostu4/fix_pusher_block. Authored-by: zhangzhao.08 <zhangzhao.08@bytedance.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 9e04ff4) Signed-off-by: Wang, Fei <fwang12@ebay.com>
|
thanks, merged to 0.6.0, 0.5.3 and branch-0.4 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix DataPusher be blocked for a long time
Why are the changes needed?
The worker has been at a performance bottleneck for a long time, the slow start strategy adjusts its maxInFlight to 1, which may cause RequestInFlight to exceed maxInFlight. If the task’s main thread has been blocked in the waitIdleQueueFullWithLock call, then the main thread will not be able to detect the sending failure since this failure changes the exception in the push state, and the waitIdleQueueFullWithLock function does not check for it
Does this PR introduce any user-facing change?
NO
How was this patch tested?
GA