[CELEBORN-1801] Remove out-of-dated flink 1.14 and 1.15 #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
reviewed
Dec 24, 2024
codenohup
force-pushed
the
remove-flink14and15
branch
from
13ca5af to
c0863f0
Compare
SteNicholas
approved these changes
Dec 24, 2024
codenohup
force-pushed
the
remove-flink14and15
branch
from
c0863f0 to
299a43b
Compare
reswqa
approved these changes
Dec 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3029 +/- ##
==========================================
- Coverage 32.99% 32.67% -0.31%
==========================================
Files 331 336 +5
Lines 19842 20032 +190
Branches 1787 1792 +5
==========================================
- Hits 6545 6544 -1
- Misses 12933 13124 +191
Partials 364 364 ☔ View full report in Codecov by Sentry. |
|
Thanks for driving this, merged to main for 0.6 |
reswqa
pushed a commit
that referenced
this pull request
Dec 31, 2024
…fleEnvironmentWrapper, SimpleResultPartitionAdapter to flink common module ### What changes were proposed in this pull request? Extract `RemoteShuffleEnvironment`, `NettyShuffleEnvironmentWrapper`, `SimpleResultPartitionAdapter` to flink common module. Meanwhile, `RemoteShuffleInputGate` and `RemoteShuffleResultPartition` are abstracted in flink common module. ### Why are the changes needed? After removing out-of-dated flink 1.14 and 1.15 in #3029, `RemoteShuffleEnvironment`, `NettyShuffleEnvironmentWrapper`, `SimpleResultPartitionAdapter` could be extracted to flink common module. Meanwhile, `RemoteShuffleInputGate` and `RemoteShuffleResultPartition` could also be abstracted in flink common module. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #3041 from SteNicholas/CELEBORN-1801. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: Weijie Guo <reswqa@163.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove out-of-dated flink 1.14 and 1.15.
For more information, please see the discussion thread: https://lists.apache.org/thread/njho00zmkjx5qspcrbrkogy8s4zzmwv9
Why are the changes needed?
Reduce maintenance burden.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Changes can be covered by existing tests.