Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Introduce Rocky Linux 9.4 support for main branch and add enhanced support for 1.5.X releases. #28

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

edespino
Copy link
Contributor

@edespino edespino commented Jun 22, 2024

This PR consists of three commits which

  • Enhance run.sh to be able to create a Cloudberry DB main branch 000-cbdb-sandbox container on Rocky Linux 9.
  • Add enhance support for 1.5.X releases. As long as the Dockerfile.RELEASE.centos7supports 1.5.x releases, a developer only needs to replace previous release zip file with new one.
  • Adjust Santbox CBDB cluster to consist of three primaries and segments so failure scenarios can be tested.
  • Parameterize which PIP Index to use.

Please review comments in the commits for additional details.

eespino added 2 commits June 22, 2024 14:25
Updated run.sh to support:

* Building against the latest release as indicated by release zip file
contained in configs directory (e.g. cloudberrydb-1.5.2.zip) and using
centos7. The Dockerfile `Dockerfile.RELEASE.centos7` will be used. The
docker file is now passed a docker variable (CODEBASE_VERSION_VAR)
which is calculated dynamically based on the version string embeded in
the release zip file.
* Building against the latest main branch and using Rocky Linux 9.
The Dockerfile `Dockerfile.main.rockylinux9` will be used.
* The CBDB cluster now has three primaries and mirrors. This will
allow developers and users to test segment failover scenarios.
* As long as the `Dockerfile.RELEASE.centos7` supports the release
zip/tar files, only the release zip file needs to be updated to
support a new release.

Here is the current usage for run.sh followed by several usage examples:

```
Usage: $0 [-o <os_version>] [-c <codebase_version>] [-b]
  -o  OS version (valid values: centos7, rockylinux9; default: $DEFAULT_OS_VERSION, or set via OS_VERSION environment variable)
  -c  Codebase version (valid values: main, or determined from release zip file name)
  -t  Timezone (default: Asia/Shanghai, or set via TIMEZONE_VAR environment variable)
  -b  Build only, do not run the container (default: false, or set via BUILD_ONLY environment variable)
```

**Example**

Build and deploy container using latest release version specified in
the zip file contained in the configs directory
(e.g. cloudberrydb-1.5.2.zip).

```
     ./run.sh
```

**Example**

Only build container using latest release version specified in the zip
file contained in the configs directory (e.g. cloudberrydb-1.5.2.zip).

```
     ./run.sh -b
```

**Example**

Only build container using main branch on Rocky Linux 9 setting the
timezone "America/Los_Angeles"

```
  ./run.sh -c main -o rockylinux9 -t "America/Los_Angeles"
```

**Example**

Only build container using main branch on Rocky Linux 9

```
  ./run.sh -c main -o rockylinux9 -b
```
* Install go package for 1.5.3 release support
* Add support for alternate location of python-dependencies.txt
* Split out configure, make and make install commands into separate
RUN sections.
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Ed Espino
❌ eespino


Ed Espino seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tuhaihe tuhaihe self-requested a review June 25, 2024 01:36
@tuhaihe
Copy link
Member

tuhaihe commented Jun 25, 2024

Great work! Thanks @edespino.
Just left some comments, FYI.

The pip install will default to using the default PIP
Index (https://pypi.org/simple). A user can supply an alternate by
using the run.sh `-p` option or set the PIP_INDEX_URL_VAR environment
variable.

Here is the run.sh -p option output:

```
-p  Python Package Index (PyPI) (default: https://pypi.org/simple, or set via PIP_INDEX_URL_VAR environment variable)
```
@tuhaihe tuhaihe self-requested a review July 15, 2024 11:52
@tuhaihe tuhaihe merged commit df6ea23 into apache:main Jul 15, 2024
1 check was pending
@edespino edespino deleted the rockylinux9.4 branch July 19, 2024 09:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants