-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introduce Rocky Linux 9.4 support for main branch and add enhanced support for 1.5.X releases. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated run.sh to support: * Building against the latest release as indicated by release zip file contained in configs directory (e.g. cloudberrydb-1.5.2.zip) and using centos7. The Dockerfile `Dockerfile.RELEASE.centos7` will be used. The docker file is now passed a docker variable (CODEBASE_VERSION_VAR) which is calculated dynamically based on the version string embeded in the release zip file. * Building against the latest main branch and using Rocky Linux 9. The Dockerfile `Dockerfile.main.rockylinux9` will be used. * The CBDB cluster now has three primaries and mirrors. This will allow developers and users to test segment failover scenarios. * As long as the `Dockerfile.RELEASE.centos7` supports the release zip/tar files, only the release zip file needs to be updated to support a new release. Here is the current usage for run.sh followed by several usage examples: ``` Usage: $0 [-o <os_version>] [-c <codebase_version>] [-b] -o OS version (valid values: centos7, rockylinux9; default: $DEFAULT_OS_VERSION, or set via OS_VERSION environment variable) -c Codebase version (valid values: main, or determined from release zip file name) -t Timezone (default: Asia/Shanghai, or set via TIMEZONE_VAR environment variable) -b Build only, do not run the container (default: false, or set via BUILD_ONLY environment variable) ``` **Example** Build and deploy container using latest release version specified in the zip file contained in the configs directory (e.g. cloudberrydb-1.5.2.zip). ``` ./run.sh ``` **Example** Only build container using latest release version specified in the zip file contained in the configs directory (e.g. cloudberrydb-1.5.2.zip). ``` ./run.sh -b ``` **Example** Only build container using main branch on Rocky Linux 9 setting the timezone "America/Los_Angeles" ``` ./run.sh -c main -o rockylinux9 -t "America/Los_Angeles" ``` **Example** Only build container using main branch on Rocky Linux 9 ``` ./run.sh -c main -o rockylinux9 -b ```
* Install go package for 1.5.3 release support * Add support for alternate location of python-dependencies.txt * Split out configure, make and make install commands into separate RUN sections.
Ed Espino seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
tuhaihe
reviewed
Jun 25, 2024
Great work! Thanks @edespino. |
The pip install will default to using the default PIP Index (https://pypi.org/simple). A user can supply an alternate by using the run.sh `-p` option or set the PIP_INDEX_URL_VAR environment variable. Here is the run.sh -p option output: ``` -p Python Package Index (PyPI) (default: https://pypi.org/simple, or set via PIP_INDEX_URL_VAR environment variable) ```
tuhaihe
approved these changes
Jul 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of three commits which
run.sh
to be able to create a Cloudberry DBmain
branch 000-cbdb-sandbox container on Rocky Linux 9.Dockerfile.RELEASE.centos7
supports 1.5.x releases, a developer only needs to replace previous release zip file with new one.Please review comments in the commits for additional details.