Feature encoding option for custom table AM #343

gfphoenix78 · 2023-12-20T06:46:04Z

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
Learn the coding contribution guide, including our code conventions, workflow and more.
List your communication in the GitHub Issues or Discussions (if has or needed).
Document changes.
Add tests for the change
Pass make installcheck
Pass make -C src/test installcheck-cbdb-parallel
Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

src/include/access/reloptions.h

src/backend/access/common/reloptions_gp.c

src/backend/commands/tablecmds.c

src/backend/access/appendonly/appendonlyam_handler.c

src/backend/commands/tablecmds.c

This commit supports custom table AM to have its own encoding options. The kernal has hard-coded encoding clause for AOCO. The guc gp_default_storage_options is only considered by AOCO, because the options may be different for other table AM.

src/backend/commands/tablecmds.c

src/backend/access/common/reloptions_gp.c

avamingli

LGTM.

This commit supports custom table AM to have its own encoding options. The kernal has hard-coded encoding clause for AOCO. The guc gp_default_storage_options is only considered by AOCO, because the options may be different for other table AM. Co-authored-by: zhoujiaqi <zhoujiaqi@hashdata.cn> Reviewed-by: Zhang Mingli <avamingli@gmail.com>

gfphoenix78 force-pushed the feature-encoding-option branch from cbb9e53 to 794087b Compare December 20, 2023 16:47