-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feature: Use amflags to support Column-oriented scanning of custom ta… #407
Merged
my-ship-it
merged 1 commit into
apache:main
from
gongxun0928:feature/use-amflags-to-support-column-oriented-scanning-of-custom-tableam
Apr 11, 2024
Merged
feature: Use amflags to support Column-oriented scanning of custom ta… #407
my-ship-it
merged 1 commit into
apache:main
from
gongxun0928:feature/use-amflags-to-support-column-oriented-scanning-of-custom-tableam
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GongXun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
c9d0a10
to
67e15e8
Compare
my-ship-it
reviewed
Apr 11, 2024
my-ship-it
reviewed
Apr 11, 2024
gfphoenix78
reviewed
Apr 11, 2024
…bleam For custom tableam, maybe it support column-oriented scanning, the postgres planner can no longer use whether am_handler is aocs handler to decide whether only to add the columns required by the operator to the targetlist, but use amflags to determine If table am supports column-oriented scanning, the flags returned by set_flags will set the SCAN_SUPPORT_COLUMN_ORIENTED_SCAN bit.
67e15e8
to
43860ff
Compare
gfphoenix78
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
foreyes
pushed a commit
to foreyes/cloudberrydb
that referenced
this pull request
Jul 8, 2024
…bleam (apache#407) For custom tableam, maybe it support column-oriented scanning, the postgres planner can no longer use whether am_handler is aocs handler to decide whether only to add the columns required by the operator to the targetlist, but use amflags to determine If table am supports column-oriented scanning, the flags returned by set_flags will set the SCAN_SUPPORT_COLUMN_ORIENTED_SCAN bit. Co-authored-by: GongXun <gongxun@hashdata.cn>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #ISSUE_Number
Change logs
For custom tableam, maybe it support column-oriented scanning, the postgres planner can no longer use whether am_handler is aocs table_am to decide whether only to add the columns required by the operator to the targetlist.
If table am supports column-oriented scanning, the flags returned by set_flags set the SCAN_SUPPORT_COLUMN_ORIENTED_SCAN bit.
Why are the changes needed?
I hope that custom column storage can also scan only necessary columns, instead of only aocs table am support
Does this PR introduce any user-facing change?
no
How was this patch tested?
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳