Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix motion toast error. #436

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix motion toast error. #436

merged 1 commit into from
May 15, 2024

Conversation

gfphoenix78
Copy link
Contributor

@gfphoenix78 gfphoenix78 commented May 14, 2024

slot->tts_isnull cannot be read before invoking slot_getallattrs.

Fix Github Issue 16906.

Authored-by: wenxing.yaun wenxing.yuan@esgyn.cn


How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

slot->tts_isnull cannot be read before invoking slot_getallattrs.

Fix Github Issue 16906.

Authored-by: wenxing.yaun <wenxing.yuan@esgyn.cn>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gfphoenix78 gfphoenix78 requested a review from my-ship-it May 14, 2024 13:25
@gfphoenix78
Copy link
Contributor Author

The issue was inherited from greenplum, see https://github.com/greenplum-db/gpdb/issues/16906
It had been fixed in https://github.com/greenplum-db/gpdb/pull/16907
This PR is simply a cherry-pick.

@avamingli avamingli added the cherry-pick cherry-pick upstream commts label May 14, 2024
@gfphoenix78 gfphoenix78 merged commit 0592389 into apache:main May 15, 2024
9 of 10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
slot->tts_isnull cannot be read before invoking slot_getallattrs.

Fix Github Issue 16906.

Authored-by: wenxing.yaun <wenxing.yuan@esgyn.cn>

Co-authored-by: HelloYJohn <xxdrywx@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-pick cherry-pick upstream commts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants