Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[AQUMV] Support DISTINCT clause on origin query. #439

Merged
merged 1 commit into from
May 17, 2024

Conversation

avamingli
Copy link
Contributor

@avamingli avamingli commented May 16, 2024

SELECT DISTINCT clause references are processed in target list, open it on origin query.
DISTINCT in aggregation and Group By DISTINCT are already supported, add cases to verify that.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

  select DISTINCT c2 from t1 where c1 > 90;

  select count(DISTINCT c2) from t1 where c1 > 90;

  select c1, c2, c3, sum(c4) from t1 where c1 > 90
  group by DISTINCT rollup(c1, c2), rollup(c1, c3);

Could be rewritten to:

  select DISTINCT mc2 from mv;

  select count(DISTINCT mc2) from mv;

  select mc1, mc2, mc3, sum(mc4) from mv
  group by DISTINCT rollup(mc1, mc2), rollup(mc1, mc3);

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

SELECT DISTINCT clause references are processed in target
list, open it on origin query.
DISTINCT in aggregation and Group By DISTINCT are already
supported, add cases to verify that.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

  select DISTINCT c2 from t1 where c1 > 90;

  select count(DISTINCT c2) from t1 where c1 > 90;

  select c1, c2, c3, sum(c4) from t1 where c1 > 90
  group by DISTINCT rollup(c1, c2), rollup(c1, c3);

Could be rewritten to:

  select DISTINCT mc2 from mv;

  select count(DISTINCT mc2) from mv;

  select mc1, mc2, mc3, sum(mc4) from mv
  group by DISTINCT rollup(mc1, mc2), rollup(mc1, mc3);

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli requested review from yjhjstz and my-ship-it May 16, 2024 06:29
@yjhjstz
Copy link
Member

yjhjstz commented May 16, 2024

icw-orca-test failed.

@my-ship-it my-ship-it merged commit fd453bf into apache:main May 17, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants