Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ignore of direct table test files. #502

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

avamingli
Copy link
Contributor

This is introduced by direct table commits, each time run regress test will get files as below.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        expected/directory_table.out
        expected/directory_table_optimizer.out
        sql/directory_table.sql

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

This is introduced by direct table commits, each time run regress
test will get files as below.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        expected/directory_table.out
        expected/directory_table_optimizer.out
        sql/directory_table.sql

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli merged commit c87fc6d into apache:main Jul 8, 2024
10 checks passed
@avamingli avamingli deleted the fix_direct_ignore branch July 8, 2024 02:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants