Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Cleanup 6] Doc: update the NOTICE and LICENSE files #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Dec 24, 2024

Fixes #ISSUE_Number

What does this PR do?

Before donating Cloudberry to the Apache Incubator, we made some adjustments to LICENSE and NOTICE files, as reflected in the git blame history. However, those changes introduced unnecessary entries that didn't fully align with Apache guidelines. This commit refines these files to better comply with Apache standards and reflects the latest changes in the project source code.

The COPYRIGHT file, inherited from the PostgreSQL upstream, served a similar purpose as the NOTICE file. As it is redundant, it has been removed from this commit.

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 24, 2024

Notes for your information:

  • the COPYRIGHT file, inherited from PostgreSQL, served a similar purpose as the NOTICE file. So delete it directly.
  • For the old NOTICE, like libuv, Zstandard software and Xerces-C descriptions, they were added incorrectly before joining the ASF last year. Cloudberry does not include their codes, so delete these lines directly.

@avamingli
Copy link
Contributor

  • like libuv, Zstandard software and Xerces-C descriptions, they were added incorrectly before joining the ASF last year. Cloudberry does not include their codes, so delete these lines directly.

libuv is used in ic_proxy since Greenplum:

@avamingli
Copy link
Contributor

  • Zstandard, Xerces

They are used in codes too.

@avamingli
Copy link
Contributor

If you make any modifications to the C code, it's important to note that you typically cannot use the "skip CI" flag. Even small changes, like adjustments to the output text, may result in regression differences.

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 24, 2024

  • Zstandard, Xerces

They are used in codes too.

Ok. I want to confirm that if these three project codes are included in the repo, or just link them dynamically?

@tuhaihe
Copy link
Member Author

tuhaihe commented Dec 24, 2024

If you make any modifications to the C code, it's important to note that you typically cannot use the "skip CI" flag. Even small changes, like adjustments to the output text, may result in regression differences.

yes, correct. Will remove the tag to trigger the CI again.

@tuhaihe tuhaihe changed the title [skip ci] Doc: update the NOTICE and LICENSE files Doc: update the NOTICE and LICENSE files Dec 24, 2024
@tuhaihe tuhaihe marked this pull request as draft December 24, 2024 09:37
@tuhaihe tuhaihe changed the title Doc: update the NOTICE and LICENSE files [Cleanup 6] Doc: update the NOTICE and LICENSE files Feb 18, 2025
@tuhaihe tuhaihe force-pushed the license-header-1-20241224 branch from fe61fc8 to 1c4d0c8 Compare February 18, 2025 11:14
@tuhaihe
Copy link
Member Author

tuhaihe commented Feb 19, 2025

  • Zstandard, Xerces

They are used in codes too.

Ok. I want to confirm that if these three project codes are included in the repo, or just link them dynamically?

After confirmation, these dependencies are only linked dynamically, not shipped in the codebase.

Before donating Cloudberry to the Apache Incubator, we made some
adjustments to LICENSE and NOTICE files, as reflected in the git blame
history. However, those changes introduced unnecessary entries that
didn't fully align with Apache guidelines. This commit refines these
files to better comply with Apache standards and reflects the latest
changes in the project source code.

The COPYRIGHT file, inherited from the PostgreSQL upstream, served a
similar purpose as the NOTICE file. As it is redundant, it has been
removed from this commit.

And introducing one new dir named `licenses` for a clearer licenses
management.
@tuhaihe tuhaihe force-pushed the license-header-1-20241224 branch from 07dbd62 to 2fb9ba9 Compare February 19, 2025 09:57
@tuhaihe tuhaihe marked this pull request as ready for review February 19, 2025 10:08
@tuhaihe
Copy link
Member Author

tuhaihe commented Feb 20, 2025

For the files src/include/port/win32_msvc/glob.h & src/port/glob.c under BSD-4-Caluse ((University of California-Specific)), seems are listed on CatX1, maybe we need to pay attention to this?

Footnotes

  1. https://www.apache.org/legal/resolved.html#category-x

@tuhaihe
Copy link
Member Author

tuhaihe commented Feb 21, 2025

Hi dear mentors, @WillemJiang @yaooqinn @rvs could you please help take a look? Thanks!

@tuhaihe tuhaihe requested review from rvs and WillemJiang February 21, 2025 06:37
@tuhaihe tuhaihe requested a review from yaooqinn February 21, 2025 06:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants