Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

api,ui: multi arch improvements #10289

Draft
wants to merge 20 commits into
base: 4.20
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jan 28, 2025

Description

TBA

  • UI changes to display architecture fields for resources.
  • API and UI changes to allow filtering resources using arch

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0.71301% with 557 lines in your changes missing coverage. Please review.

Project coverage is 15.99%. Comparing base (c80b886) to head (59f2608).
Report is 36 commits behind head on 4.20.

Files with missing lines Patch % Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java 0.00% 187 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 57 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java 1.75% 56 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java 0.00% 47 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 36 Missing ⚠️
utils/src/main/java/com/cloud/utils/HttpUtils.java 0.00% 36 Missing ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java 0.00% 34 Missing ⚠️
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java 0.00% 20 Missing ⚠️
...src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java 0.00% 19 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 14 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##               4.20   #10289    +/-   ##
==========================================
  Coverage     15.99%   15.99%            
- Complexity    13081    13104    +23     
==========================================
  Files          5649     5651     +2     
  Lines        495648   496149   +501     
  Branches      60006    60082    +76     
==========================================
+ Hits          79265    79377   +112     
- Misses       407537   407910   +373     
- Partials       8846     8862    +16     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 16.83% <0.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr changed the title ui: multi arch improvements api,ui: multi arch improvements Jan 29, 2025
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant