Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Launch RESIZE event on volume snapshot revert #10482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

julien-vaz
Copy link
Contributor

Description

On volume snapshot revert, if its logical size was changed after the snapshot creation, its size is updated to the previous one, yet, no event is launched on the Usage server pointing to this change.

This behavior was modified, so that a RESIZE event is launched on the Usage server, if the volume's size has been changed after a snapshot revert.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

  1. A volume snapshot was created;
  2. The resize operation was done;
  3. The snapshot was reverted;
  4. On the usage_event table the VOLUME.RESIZE event was launched with the previous size.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (24b7c66) to head (3dd3aec).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...om/cloud/storage/snapshot/SnapshotManagerImpl.java 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main   #10482       +/-   ##
============================================
+ Coverage     4.00%   16.15%   +12.15%     
- Complexity       0    13274    +13274     
============================================
  Files          396     5666     +5270     
  Lines        32530   498088   +465558     
  Branches      5766    60270    +54504     
============================================
+ Hits          1302    80480    +79178     
- Misses       31078   408593   +377515     
- Partials       150     9015     +8865     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <28.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Julien Hervot de Mattos Vaz and others added 2 commits March 5, 2025 13:51
@julien-vaz
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12666

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12683

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants