-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Launch RESIZE event on volume snapshot revert #10482
base: main
Are you sure you want to change the base?
Launch RESIZE event on volume snapshot revert #10482
Conversation
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10482 +/- ##
============================================
+ Coverage 4.00% 16.15% +12.15%
- Complexity 0 13274 +13274
============================================
Files 396 5666 +5270
Lines 32530 498088 +465558
Branches 5766 60270 +54504
============================================
+ Hits 1302 80480 +79178
- Misses 31078 408593 +377515
- Partials 150 9015 +8865
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Applies suggestion Co-authored-by: dahn <daan.hoogland@gmail.com>
@blueorangutan package |
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12666 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12683 |
Description
On volume snapshot revert, if its logical size was changed after the snapshot creation, its size is updated to the previous one, yet, no event is launched on the Usage server pointing to this change.
This behavior was modified, so that a RESIZE event is launched on the Usage server, if the volume's size has been changed after a snapshot revert.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
usage_event
table theVOLUME.RESIZE
event was launched with the previous size.