Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve Quota Statement #10506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julien-vaz
Copy link
Contributor

Description

In the current version, the quotaStatement API is returning the internal ID for account and domain, which is not useful for users, since all APIs use/return the UUID. Also, when the usage_type parameter is informed, the API shows dummy records.

To address those problems:

  • the API was modified so it returns the resources' UUID;
  • the dummy records bug was fixed;
  • a new parameter showresources was added to display more information to the user about each usage type;
  • a new quotaStatementDetails API was created to list more details about each usage type;

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

On CloudMonkey the quotaStatement API was called and:

  • the resources' UUID was returned instead of the internal ID;
  • when specified a usage_type no dummy records were showed;
  • the showresources parameter is properly working;

The quotaStatementDetails API was called successfully as well.

@julien-vaz
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12669

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.00%. Comparing base (69cf299) to head (9617344).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (69cf299) and HEAD (9617344). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (69cf299) HEAD (9617344)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10506       +/-   ##
=============================================
- Coverage     16.15%    4.00%   -12.16%     
=============================================
  Files          5666      396     -5270     
  Lines        498081    32532   -465549     
  Branches      60267     5767    -54500     
=============================================
- Hits          80475     1302    -79173     
+ Misses       408593    31080   -377513     
+ Partials       9013      150     -8863     
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@winterhazel winterhazel self-requested a review March 6, 2025 13:06
@julien-vaz
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12689

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants