UI improvements #9773

abh1sar · 2024-10-06T15:34:28Z

Description

This PR does multiple UI improvements

Autofill vCenter host, datacenter and credentials while adding cluster using the zone wide value from vmware_data_center table
Show Usage settings as a different pane in global settings
Option to attach the volume to an instance during volume create.
Show mgmt server's service ip in the details tab of Infrastructure -> Management server.
Don't display create volume snapshot button in the Instance tab for KVM, if the instance is running and "kvm.snapshot.enabled" is false. (Also contains some code cleanup in storage.js)
The name Recurring snapshots is used everywhere except for one place where 'Scheduled' snapshots is used in the Recurring Snapshots form. Change it to Recurring Snapshots.
Reorder the Hypervisor list shown everywhere in order of popularity.

Items 1,3,4,5,6 are UI only changes, and can be tested with just the UI.

Doc PR : apache/cloudstack-documentation#448

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>

…l-snapshots

codecov · 2024-10-06T15:41:49Z

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (7e295ec) to head (c59c122).
Report is 39 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...udstack/api/response/ManagementServerResponse.java	0.00%	4 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	0.00%	4 Missing ⚠️
...com/cloud/network/vpn/Site2SiteVpnManagerImpl.java	0.00%	2 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9773      +/-   ##
============================================
- Coverage     16.14%   16.00%   -0.15%     
- Complexity    12972    13065      +93     
============================================
  Files          5639     5644       +5     
  Lines        494299   494915     +616     
  Branches      59909    59960      +51     
============================================
- Hits          79789    79195     -594     
- Misses       405685   406883    +1198     
- Partials       8825     8837      +12

Flag	Coverage Δ
uitests	`4.01% <ø> (-0.01%)`	⬇️
unittests	`16.84% <8.33%> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abh1sar · 2024-10-06T18:22:34Z

@blueorangutan package

blueorangutan · 2024-10-06T18:24:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-06T19:30:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11289

abh1sar · 2024-10-07T03:59:56Z

@blueorangutan ui

blueorangutan · 2024-10-07T04:01:03Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-10-07T04:17:49Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9773 (QA-JID-461)

DaanHoogland · 2024-10-07T13:39:09Z

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

abh1sar · 2024-10-08T01:23:22Z

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

@DaanHoogland You are right.
These items contain db changes for which full testing will be required
2. Show Usage settings as a different pane in global settings
7. Reorder the Hypervisor list shown everywhere in order of popularity.

For the rest of the items, ui testing is enough.

P.S I have added db changes to schema-41900to42000 for now. Will move it to schema-42000-42010 once CloudStack version changes to 4.20.1. Will keep this PR in draft until then.

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql

Pearl1594

clgtm, just a few queries.

Pearl1594 · 2024-10-10T01:02:12Z

ui/src/config/section/compute.js

-            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') ||
-              (['Stopped'].includes(record.state) && !['KVM', 'LXC'].includes(record.hypervisor)))
+          show: (record, store) => {
+            return (record.hypervisor !== 'KVM') ||


why destroyed state?

I tried to keep the UI conditions same as the service layer. Please see hostSupportsSnapsthotForVolume().

But I'm ok if we don't want to allow snapshot creation from UI for destroyed VMs.

Pearl1594 · 2024-10-10T01:02:42Z

ui/src/config/section/storage.js

-                record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+            return record.state === 'Ready' &&
+              (record.hypervisor !== 'KVM' ||
+               ['Stopped', 'Destroyed'].includes(record.vmstate) ||


same here, why destroyed state ?

Same as above

Before this change, the button would be shown for all states part from 'Running'.
Now it will only be shown for 'Stopped' or 'Destroyed' states

Pearl1594 · 2024-10-10T01:02:57Z

ui/src/config/section/storage.js

-                record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+            return record.state === 'Ready' &&
+              (record.hypervisor !== 'KVM' ||
+               (['Stopped', 'Destroyed'].includes(record.vmstate)) ||


same doubt as above

Same as above

blueorangutan · 2024-10-10T06:29:10Z

[SF] Trillian Build Failed (tid-11647)

rajujith

All the mentioned fixes works fine.

abh1sar · 2025-01-13T12:38:59Z

@blueorangutan ui

blueorangutan · 2025-01-13T12:40:04Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

abh1sar · 2025-01-13T12:53:33Z

@blueorangutan package

blueorangutan · 2025-01-13T12:54:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-01-13T12:57:36Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9773 (QA-JID-505)

blueorangutan · 2025-01-13T14:02:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12070

abh1sar · 2025-01-14T10:58:11Z

@blueorangutan test

blueorangutan · 2025-01-14T11:00:08Z

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-15T05:37:16Z

[SF] Trillian test result (tid-12106)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 64215 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t12106-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	`Error`	2.27	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.41	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.41	test_ipv4_routing.py
test_06_purge_expunged_vm_background_task	`Failure`	394.68	test_purge_expunged_vms.py

abh1sar · 2025-01-24T06:08:45Z

Test failures are not related to the change, which is mostly ui.

andrijapanicsb

LGTM, based on 4-eyes review of the UI (Simulator)

server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java

…pl.java

andrijapanicsb · 2025-02-05T12:07:25Z

(committed just the changed message/language that @abh1sar probably didn't see - hope that is OK)

rohityadavcloud · 2025-02-05T12:08:05Z

@blueorangutan package

blueorangutan · 2025-02-05T12:10:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-05T13:18:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12344

Failures seen in apache#10006 (comment) and others. With apache#9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. THis was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Failures seen in #10006 (comment) and others. With #9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. This was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

abh1sar and others added 10 commits October 1, 2024 13:48

Show Usage Server configuration in a separate pane

eccb2e3

UI: Option to attach volume to an instance during create volume

fb46785

Merge branch '4.19'

c087de4

Show service ip in management server details tab

0a097c4

change Schedule Snapshots to Recurring Snapshots

0d024c3

Change the hypervisor order so that kvm, vmware, xenserver show up first

f53092e

Remove extra space in hypervisor names in config.java

a79b603

Fix updateTemplatePermission when the UI is set to a language other…

d6181d5

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>

Autofill vcenter details in add cluster form

e666800

UI: condition to display create vm-vol-snapshots to same as create vo…

88ad004

…l-snapshots

boring-cyborg bot added the component:UI label Oct 6, 2024

abh1sar marked this pull request as draft October 6, 2024 18:14

DaanHoogland added the component:database label Oct 7, 2024

abh1sar added this to the 4.20.1.0 milestone Oct 8, 2024

rohityadavcloud reviewed Oct 8, 2024

View reviewed changes

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql Outdated Show resolved Hide resolved

abh1sar requested review from rajujith and andrijapanicsb October 8, 2024 12:04

Pearl1594 approved these changes Oct 10, 2024

View reviewed changes

rajujith reviewed Oct 10, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into ui-improv

8fdfbdd

abh1sar removed the distro:ubuntu label Jan 13, 2025

remove "schedule" from message in create Recurring Snapshots form

a7a8cdf

abh1sar mentioned this pull request Jan 20, 2025

Adding new ESX cluster allows for operator to enter data in immutable fields #6923

Closed

abh1sar added the status:ready-for-merge label Jan 24, 2025

Merge branch '4.20' into ui-improv

6442663

rohityadavcloud closed this Feb 5, 2025

rohityadavcloud reopened this Feb 5, 2025

andrijapanicsb approved these changes Feb 5, 2025

View reviewed changes

server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java Outdated Show resolved Hide resolved

Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerIm…

c59c122

…pl.java

rohityadavcloud removed the status:ready-for-merge label Feb 5, 2025

rohityadavcloud merged commit c5afee2 into apache:4.20 Feb 6, 2025
24 of 26 checks passed

abh1sar deleted the ui-improv branch February 7, 2025 04:22

shwstppr mentioned this pull request Mar 5, 2025

test: fix failure in test_06_purge_expunged_vm_background_task #10501

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI improvements #9773

UI improvements #9773

abh1sar commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading

abh1sar commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

abh1sar commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

DaanHoogland commented Oct 7, 2024

abh1sar commented Oct 8, 2024 •

edited

Loading

Pearl1594 left a comment

Pearl1594 Oct 10, 2024

abh1sar Oct 10, 2024

Pearl1594 Oct 10, 2024

abh1sar Oct 10, 2024

abh1sar Oct 10, 2024

Pearl1594 Oct 10, 2024

abh1sar Oct 10, 2024

blueorangutan commented Oct 10, 2024

rajujith left a comment •

edited

Loading

abh1sar commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

abh1sar commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

abh1sar commented Jan 14, 2025

blueorangutan commented Jan 14, 2025

blueorangutan commented Jan 15, 2025

abh1sar commented Jan 24, 2025

andrijapanicsb left a comment

andrijapanicsb commented Feb 5, 2025

rohityadavcloud commented Feb 5, 2025

blueorangutan commented Feb 5, 2025

blueorangutan commented Feb 5, 2025

UI improvements #9773

UI improvements #9773

Conversation

abh1sar commented Oct 6, 2024 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Oct 6, 2024 • edited Loading

Codecov Report

abh1sar commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

abh1sar commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

DaanHoogland commented Oct 7, 2024

abh1sar commented Oct 8, 2024 • edited Loading

Pearl1594 left a comment

Choose a reason for hiding this comment

Pearl1594 Oct 10, 2024

Choose a reason for hiding this comment

abh1sar Oct 10, 2024

Choose a reason for hiding this comment

Pearl1594 Oct 10, 2024

Choose a reason for hiding this comment

abh1sar Oct 10, 2024

Choose a reason for hiding this comment

abh1sar Oct 10, 2024

Choose a reason for hiding this comment

Pearl1594 Oct 10, 2024

Choose a reason for hiding this comment

abh1sar Oct 10, 2024

Choose a reason for hiding this comment

blueorangutan commented Oct 10, 2024

rajujith left a comment • edited Loading

Choose a reason for hiding this comment

abh1sar commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

abh1sar commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

blueorangutan commented Jan 13, 2025

abh1sar commented Jan 14, 2025

blueorangutan commented Jan 14, 2025

blueorangutan commented Jan 15, 2025

abh1sar commented Jan 24, 2025

andrijapanicsb left a comment

Choose a reason for hiding this comment

andrijapanicsb commented Feb 5, 2025

rohityadavcloud commented Feb 5, 2025

blueorangutan commented Feb 5, 2025

blueorangutan commented Feb 5, 2025

abh1sar commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading

abh1sar commented Oct 8, 2024 •

edited

Loading

rajujith left a comment •

edited

Loading