Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: drop node 6 and 8 support #832

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 26, 2019

Motivation and Context

Description

  • Removes Node 6 and 8 from CI Testing Services
  • Bump engines.node to >=10 in package.json

Testing

  • npm t
  • CI services continue to pass

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 9.0.0 milestone Sep 26, 2019
@erisu erisu mentioned this pull request Sep 26, 2019
1 task
@codecov-io
Copy link

Codecov Report

Merging #832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files          19       19           
  Lines        1860     1860           
=======================================
  Hits         1233     1233           
  Misses        627      627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35a990...407d36e. Read the comment docs.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this please do not merge yet, as this is a BREAKING CHANGE

@erisu
Copy link
Member Author

erisu commented Jan 6, 2020

Since the repo has been bumped (#890) for next major, I will continue with merging in this PR.

@erisu erisu merged commit e26142f into apache:master Jan 6, 2020
@erisu erisu deleted the drop-node-6-8 branch January 6, 2020 03:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants