Check that bin/cordova works on Travis CI #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that bin script actually runs on current Node.js version to detect and avoid bugs such as apache#339
raphinesse
approved these changes
Sep 27, 2018
|
I forgot to mention that the build is failing on Node.js 4 due to #339. I expect it should go green if we rebase on the upcoming bug fix. |
brodycj
pushed a commit
to brodycj/cordova-cli
that referenced
this pull request
Sep 27, 2018
Ensure that bin script actually runs on current Node.js version to detect and avoid bugs such as apache#339 Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
brodycj
pushed a commit
that referenced
this pull request
Sep 27, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that bin script actually runs on current Node.js version to detect and avoid bugs like #339