Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dep(npm): bump dependencies to latest minor & patch revision #587

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 18, 2022

Platforms affected

n/a

Motivation, Context & Description

  • Update package.json and package-lock.json with latest minor and patch revisions

Testing

  • npm t
  • GitHub Actions

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #587 (472acef) into master (6cf1e36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files           4        4           
  Lines         318      318           
=======================================
  Hits          223      223           
  Misses         95       95           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mihai1iMob
Copy link

Mihai1iMob commented Nov 28, 2022

Would be nice to upgrade update-notifier to at least next major vers ^6.0.2 since having other libs using a higher version for it will get the latest @types/responselike@3.0.0 which is an empty stub since responselike now provides its own types definitions and TS gives the following project "error":

TS2688: Cannot find type definition file for 'responselike'. The file is in the program because: Entry point for implicit type library 'responselike'

more info:
image

@breautek
Copy link
Contributor

Would be nice to upgrade update-notifier to at least next major vers ^6.0.2

It's kind of planned but it is a huge breaking change because the package has turned into pure ESM which isn't compatible with CommonJS code.

So our options is to:

Drop the package altogether and hopefully find a replacement

Might be a stopgap solution. The update notifier is nice-to-have, and honestly wouldn't be too difficult to implement a notifier ourselves. But the author of the package is like a NPM module rock star with literally thousands of commonly used packages and he's been converting all of his packages. I'm sure Cordova has other dependencies from the same author that we will eventually run into a similar issue with.

Convert Cordova to ESM which will be a quite a time consuming process.

Is likely the best approach forward but it's very time consuming because as you migrate packages to ESM, it will break any dependents that are trying to use it in a CommonJS style (via require). So the entire Cordova framework effectively will need to become ESM modules, and then of course it will break third-party tooling that has Cordova has a dependency.

Introduce build tools into our Cordova repos to convert ESM packages back to commonjs.

I know this doesn't have good support with the community. It introduces complexities and makes it so you can't simply install a dev/test version from github (cause ideally generated files will be git ignored).

@erisu erisu merged commit 0538ddc into apache:master Nov 28, 2022
@erisu erisu deleted the feat/bump-deps branch November 28, 2022 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants