Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: drop node 6 and 8 support #90

Merged
merged 1 commit into from
Nov 6, 2019
Merged

chore: drop node 6 and 8 support #90

merged 1 commit into from
Nov 6, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 26, 2019

Motivation and Context

Description

  • Removes Node 6 and 8 from CI Testing Services
  • Bump engines.node to >=10 in package.json

Testing

  • npm t
  • CI services continue to pass

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Sep 26, 2019
timbru31
timbru31 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this please do not merge yet, as this is a BREAKING CHANGE

@erisu erisu merged commit 7ceeeb4 into apache:master Nov 6, 2019
@erisu erisu deleted the drop-node-6-8 branch November 6, 2019 06:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @timbru31