Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

4.2.4 patch update #155

Closed
wants to merge 8 commits into from
Closed

Conversation

brodycj
Copy link

@brodycj brodycj commented Jun 18, 2018

Platforms affected

All

What does this PR do?

Proposed changes for 4.2.x branch (NOT for master):

  • Use npm@5 on AppVeyor to resolve issue with CI on Node.js 4
  • Drop support for old Cordova platforms
  • Use github:brodybits/jasmine-node#1.15.0-rc1 in devDependencies to resolve npm audit warning (see note below)
  • CB-9366 Log error.stack as proposed by @nikhilkh in CB-9366 Log error.stack as it helps with diagnosing the source of the… #118, with JavaScript fix by @brodybits
  • Update version & RELEASENOTES.md for release 4.2.4
  • Increment package version to 4.2.5-dev

NOTE: github:brodybits/jasmine-node#1.15.0-rc1 specifies a special version of jasmine-node that I made in my fork with changes proposed in mhevery/jasmine-node#429 to resolve npm audit issues. This special version is needed due to lack of maintenance as discussed in mhevery/jasmine-node#430. I already requested owner access to the NPM module according to https://www.npmjs.com/policies/disputes, may have to wait a month for this.

The use of brodybits/jasmine-node patch will NOT be part of master. The solution for the next major release is to migrate to jasmine, with some changes to require() imports, as proposed by @audreyso in #140.

What testing has been done on this change?

  • Most of these changes were verified to pass CI in @151 and a couple other PRs that I had closed.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodycj
Copy link
Author

brodycj commented Jun 18, 2018

Changed my mind yet again: need to fix some more npm build/test issues and maybe propose the changes in smaller parts. Closing for now, at least. Apologies to watchers for the confusion.

@brodycj brodycj closed this Jun 18, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants