refactor: Removed obsolete copyResource function #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Removes a copied/pasted function in accordance to it's TODO. The pasted
copyResource
function appeared to be a stopgap measure to address a bug that appeared pre cordova-android@4. The note said to remove the function and bring the requiredcordova-android
engine to >= 4.0.0The plugin currently requires
cordova-android
>= 6.3.0 so no changes there was required.Description
Deleted local copy of
copyResource
and replaced usages withCordovaResourceApi
version.Testing
ran
npm test
and manually usedcopyTo
api.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)