Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Removed obsolete copyResource function #433

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Removes a copied/pasted function in accordance to it's TODO. The pasted copyResource function appeared to be a stopgap measure to address a bug that appeared pre cordova-android@4. The note said to remove the function and bring the required cordova-android engine to >= 4.0.0

The plugin currently requires cordova-android >= 6.3.0 so no changes there was required.

Description

Deleted local copy of copyResource and replaced usages with CordovaResourceApi version.

Testing

ran npm test and manually used copyTo api.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek force-pushed the remove-copyResource branch from 75dfec4 to 904c413 Compare October 22, 2020 23:59
@breautek breautek merged commit a73fc11 into apache:master Oct 26, 2020
@breautek breautek deleted the remove-copyResource branch October 26, 2020 11:55
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants