Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(android): fix tests to use cordova-android 10.x default https scheme #518

Merged
merged 2 commits into from
Mar 30, 2022
Merged

test(android): fix tests to use cordova-android 10.x default https scheme #518

merged 2 commits into from
Mar 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 30, 2022 •
edited
Loading

Platforms affected

android

Motivation and Context

tests failing with Cordova-Android 10.x because default scheme has changed to https.

Description

Update the test's default scheme to https for android.

Testing

  • test specs

Checklist

  • I've run the tests to see all new and existing tests pass
  • I updated automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested review from NiklasMerz and breautek March 30, 2022 06:30
@erisu erisu changed the title test(android): fix tests to run on cordova-android 10.x that defaults… test(android): fix tests to use cordova-android 10.x default https scheme Mar 30, 2022
@erisu erisu force-pushed the fix/test-on-android-10x branch from 83a6fcd to e161fbc Compare March 30, 2022 07:12
@erisu erisu force-pushed the fix/test-on-android-10x branch from e161fbc to c946b78 Compare March 30, 2022 07:18
@erisu erisu merged commit e97fe90 into apache:master Mar 30, 2022
@erisu erisu deleted the fix/test-on-android-10x branch March 30, 2022 07:19
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
@erisu @pmcquay
test(android): fix tests to use cordova-android 10.x default https sc…
e962f86 
…heme (apache#518)

* test(android): fix tests to run on cordova-android 10.x that defaults to https scheme
* style: add cordova to lint globals
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@breautek breautek Awaiting requested review from breautek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @NiklasMerz