fix(types): Mark FileWriter.write to support ArrayBuffer data #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileWriter.js clearly supports this type, and it allows memory conscious users to avoid unnecessary duplication of the memory as occurs when using a Blob.
Platforms affected
Type-only change
Motivation and Context
Avoid forcing unnecessary duplication of memory when attempting to write files
Description
Clarifies
FileWriter.write
type definition to properly reflect the method's support for anArrayBuffer
type directly:cordova-plugin-file/www/FileWriter.js
Line 156 in c883998
Testing
Type-only change. Have confirmed new type behaves correctly with code passing in an ArrayBuffer.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)